Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KOA-4949 Update FloatingPanel from 1.6.6 to 2.5.2 #1324

Merged
merged 14 commits into from
Jun 17, 2022

Conversation

gert-janvercauteren
Copy link
Contributor

Update the floating panel layout to the latest release (2.5.2)

Remember to include the following changes:

If you are curious about how we review, please read through the code review guidelines

@gert-janvercauteren gert-janvercauteren self-assigned this Jun 9, 2022
Copy link
Contributor

@frugoman frugoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just super small comments/questions.
dont forget the UNRELEASED file

@gert-janvercauteren gert-janvercauteren marked this pull request as ready for review June 10, 2022 06:06
@gert-janvercauteren gert-janvercauteren added the major Breaking change label Jun 13, 2022
# Conflicts:
#	Example/Podfile.lock
#	UNRELEASED.md
@gert-janvercauteren gert-janvercauteren changed the title KOA-4949 update floating panel KOA-4949 Update FloatingPanel from 1.6 to 2.5.2 Jun 17, 2022
@gert-janvercauteren gert-janvercauteren changed the title KOA-4949 Update FloatingPanel from 1.6 to 2.5.2 KOA-4949 Update FloatingPanel from 1.6.6 to 2.5.2 Jun 17, 2022
@frugoman frugoman merged commit 06ba5f6 into main Jun 17, 2022
@frugoman frugoman deleted the KOA-4949_update_floating_panel branch June 17, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants