-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented PHPStan + Propel2 beta2 #25
Conversation
…pstan/phpstan-deprecation-rules
tnx for the help i will need time to review it. |
I'm not sure if supporting PHP 7.2 and 7.3 should be a thing, because they are both end-of-life for quite some time. Symfony 4.4 on the other hand has support for another year, and Symfony 5.4 is supported for the next 3 years, so I feel that supporting those makes a lot of sense. With that in mind, maybe it could be an idea to continue the 5.0.X versions with PHP 7.2 support, if that is really desired for this bundle, just for bug fixes. Besides that there could be an introduction of 5.1.X versions with PHP 7.4 support, since that is the only way to keep using the latest Propel2 releases. |
"I'm not sure if supporting PHP 7.2 and 7.3 should be a thing, because they are both end-of-life for quite some time. Symfony 4.4 on the other hand has support for another year, and Symfony 5.4 is supported for the next 3 years, so I feel that supporting those makes a lot of sense." "With that in mind, maybe it could be an idea to continue the 5.0.X versions with PHP 7.2 support, if that is really desired for this bundle, just for bug fixes. Besides that there could be an introduction of 5.1.X versions with PHP 7.4 support, since that is the only way to keep using the latest Propel2 releases." |
Sounds good to me |
I firstly implemented PHPStan, then upgraded Propel2 to beta2, fixed a few bugs along the way.
This merge will also resolve: #23 #19 #22
I've only upgraded the 5.0 branch. The differences between the 5.0 and the 6.0 branch seem small, so it shouldn't be too hard to merge into 6.0 and resolve the conflicts (that will resolve #24).
Manually tested with Symfony 4.4 and 5.4
PHP dependency is now 7.4+ (just like Propel2 beta2)