ExifTagDescriptionAttribute doesnt need fields #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since the reflection is done on the constructor arguments
Codecov Report
@@ Coverage Diff @@
## master #978 +/- ##
==========================================
+ Coverage 89.7% 89.71% +<.01%
==========================================
Files 1097 1097
Lines 48556 48554 -2
Branches 3422 3422
==========================================
Hits 43558 43558
+ Misses 4295 4293 -2
Partials 703 703
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #978 +/- ##
==========================================
+ Coverage 89.74% 89.75% +<.01%
==========================================
Files 1098 1098
Lines 48690 48688 -2
Branches 3433 3433
==========================================
Hits 43698 43698
+ Misses 4288 4286 -2
Partials 704 704
Continue to review full report at Codecov.
|
JimBobSquarePants
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the reflection is done on the constructor arguments
Note that i am not familiar with the AOT approach in use here. so please verify my assumption