Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Decoding BI_ALPHABITFIELDS #832

Merged

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR add the support for decoding bitmaps with the compression type: BI_ALPHABITFIELDS.
This is a special kind of bitmap type which was introduced with windows CE: https://docs.microsoft.com/en-us/previous-versions/windows/embedded/aa452885(v%3Dmsdn.10)

This also fixes an issue with a rare edge case, decoding bitmaps with a less than full sized palette.

@codecov
Copy link

codecov bot commented Feb 9, 2019

Codecov Report

Merging #832 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #832      +/-   ##
==========================================
+ Coverage   88.84%   88.84%   +<.01%     
==========================================
  Files        1015     1015              
  Lines       44148    44167      +19     
  Branches     3180     3181       +1     
==========================================
+ Hits        39222    39241      +19     
  Misses       4201     4201              
  Partials      725      725
Impacted Files Coverage Δ
tests/ImageSharp.Tests/TestImages.cs 100% <ø> (ø) ⬆️
...ts/ImageSharp.Tests/Formats/Bmp/BmpDecoderTests.cs 99.01% <100%> (+0.09%) ⬆️
src/ImageSharp/Formats/Bmp/BmpDecoderCore.cs 83.59% <100%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13ff434...1208628. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 9, 2019

Codecov Report

Merging #832 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #832      +/-   ##
==========================================
+ Coverage   88.84%   88.84%   +<.01%     
==========================================
  Files        1015     1015              
  Lines       44148    44167      +19     
  Branches     3180     3181       +1     
==========================================
+ Hits        39222    39241      +19     
  Misses       4201     4201              
  Partials      725      725
Impacted Files Coverage Δ
tests/ImageSharp.Tests/TestImages.cs 100% <ø> (ø) ⬆️
...ts/ImageSharp.Tests/Formats/Bmp/BmpDecoderTests.cs 99.01% <100%> (+0.09%) ⬆️
src/ImageSharp/Formats/Bmp/BmpDecoderCore.cs 83.59% <100%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13ff434...1208628. Read the comment docs.

@JimBobSquarePants
Copy link
Member

@brianpopow Just so you know you are now known as the Bitmap King 👑

@JimBobSquarePants JimBobSquarePants merged commit 892bba1 into SixLabors:master Feb 11, 2019
antonfirsov pushed a commit to antonfirsov/ImageSharp that referenced this pull request Nov 11, 2019
* Adds support for BI_ALPHABITFIELDS

* Fix for decoding bitmaps with a less than full sized palette
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants