Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Projective Transforms #788

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Fix Projective Transforms #788

merged 1 commit into from
Dec 11, 2018

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Previously we were modifying the wrong row/column in our taper matrices and then flattening the transform using Vector3 to compensate when we should have been using Vector4 instead to take into account perspective changes. These changes update the code to fix this.

@JimBobSquarePants JimBobSquarePants added this to the 1.0.0-rc1 milestone Dec 11, 2018
@JimBobSquarePants JimBobSquarePants mentioned this pull request Dec 11, 2018
Closed
4 tasks
@JimBobSquarePants JimBobSquarePants merged commit 9446900 into master Dec 11, 2018
@JimBobSquarePants JimBobSquarePants deleted the js/fix-transforms branch December 11, 2018 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:transforms
Projects
None yet
Milestone
1.0.0-rc1
Development

Successfully merging this pull request may close these issues.
1 participant
@JimBobSquarePants