Added missing length check that caused an ArgumentNullException (#750) #753
Conversation
|
Looks like 2.1 returns an empty string instead. |
|
I have a feeling that when we fix such bugs, we always have to add end-to-end regression tests with a test image, even if a unit test has been added based on the root cause. @JimBobSquarePants @dlemstra am I overthinking? |
|
A would add the image from #750 in case we change the underlying implementation and introduce a regressive bug. |
Codecov Report
@@ Coverage Diff @@
## master #753 +/- ##
=========================================
+ Coverage 88.39% 88.4% +<.01%
=========================================
Files 996 997 +1
Lines 42314 42325 +11
Branches 3142 3142
=========================================
+ Hits 37405 37416 +11
Misses 4225 4225
Partials 684 684
Continue to review full report at Codecov.
|
| @@ -160,6 +160,8 @@ public static class Issues | |||
| public const string OrderedInterleavedProgressive723A = "Jpg/issues/Issue723-Ordered-Interleaved-Progressive-A.jpg"; | |||
| public const string OrderedInterleavedProgressive723B = "Jpg/issues/Issue723-Ordered-Interleaved-Progressive-B.jpg"; | |||
| public const string OrderedInterleavedProgressive723C = "Jpg/issues/Issue723-Ordered-Interleaved-Progressive-C.jpg"; | |||
| public const string ExifGetString750Transform = "Jpg/issues/issue750-exif-tranform.jpg"; | |||
There was a problem hiding this comment.
Small typo here. Thanks for adding these images.
There was a problem hiding this comment.
No worries, I'll update the reference file name later on, will do for now.
Added missing length check that caused an ArgumentNullException (SixLabors#750)
Prerequisites
Description
This patch adds a missing null check and also an extra unit test that checks if the extension method works. This fixes #750.