Cross target NET472 and enable extended intrinsics behind symbol #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…XTENDED_INTRINSICS symbol
5 tasks
JimBobSquarePants
approved these changes
Oct 24, 2018
|
@iamcarbon in my original proposal I supposed that the spannified stream API's are also available on .NET FW 4.7.2, but looks like the full unification is out of scope until .NET Standard 2.1 :( |
|
@antonfirsov -- Yeah. :( Even worse, their latest plan was for .NETCOREAPP3.0 to be the first runtime to implement .NETSTANDARD2.1. And it doesn't look like the desktop framework will ever implement it. There may never be a full unification. |
antonfirsov
pushed a commit
to antonfirsov/ImageSharp
that referenced
this pull request
Nov 11, 2019
Cross target NET472 and enable extended intrinsics behind symbol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR cross targets NET472 and introduces a SUPPORTS_EXTENDED_INTRINSICS symbol to enable the new extended intrinsics support on modern runtimes (NET472+ & NETCOREAPP2.1+).
This PR also retarget the NET471 tests to NET472. Extended tests continue to run against NET471.