Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EXIF overflow and Jpeg decoding #699

Merged
merged 3 commits into from
Sep 7, 2018
Merged

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR fixes the overflow error in #694 and #696
Additionally is allows the decoding of the malformed jpeg in #695

@codecov
Copy link

codecov bot commented Sep 7, 2018

Codecov Report

Merging #699 into master will increase coverage by <.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
+ Coverage   89.25%   89.26%   +<.01%     
==========================================
  Files         878      878              
  Lines       39240    39246       +6     
  Branches     2555     2561       +6     
==========================================
+ Hits        35025    35033       +8     
+ Misses       3492     3487       -5     
- Partials      723      726       +3
Impacted Files Coverage Δ
tests/ImageSharp.Tests/TestImages.cs 100% <ø> (ø) ⬆️
...Sharp.Tests/Formats/Jpg/JpegDecoderTests.Images.cs 100% <100%> (ø) ⬆️
...s/ImageSharp.Tests/Formats/Jpg/JpegDecoderTests.cs 56.45% <100%> (+1.45%) ⬆️
src/ImageSharp/Formats/Jpeg/JpegDecoderCore.cs 84.93% <66.66%> (+0.46%) ⬆️
...rc/ImageSharp/MetaData/Profiles/Exif/ExifReader.cs 69.6% <87.5%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db41194...823ee37. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants