Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly set BitsPerPixel and BitsPerSample to 1 for bicolor compressed images #2590

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Explicitly set BitsPerPixel and BitsPerSample to 1 for bicolor compressed images #2590

merged 1 commit into from
Nov 25, 2023

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Explicitly set BitsPerPixel and BitsPerSample to 1 for bicolor compressed images, fixes #2587

@JimBobSquarePants JimBobSquarePants added this to the v3.1.0 milestone Nov 25, 2023
JimBobSquarePants
JimBobSquarePants approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@JimBobSquarePants JimBobSquarePants merged commit cc4c0b1 into main Nov 25, 2023
14 checks passed
@JimBobSquarePants JimBobSquarePants deleted the bp/Issue2587 branch November 25, 2023 05:48
@kandeepandev kandeepandev mentioned this pull request Nov 29, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees
No one assigned
Labels
formats:tiff
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

The number of samples in the TIFF BitsPerSample entry is not supported.
2 participants
@brianpopow @JimBobSquarePants