Add webp decoder option to handle the background color in ANIM chunk #2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the background color in the ANIM chunk
Co-authored-by: James Jackson-South <[email protected]>
brianpopow
changed the title
antonfirsov
reviewed
Oct 12, 2023
tests/ImageSharp.Tests/TestImages.cs
Outdated
| @@ -677,6 +677,7 @@ public static class Lossy | |||
| public const string WithXmp = "Webp/xmp_lossy.webp"; | |||
| public const string BikeSmall = "Webp/bike_lossy_small.webp"; | |||
| public const string Animated = "Webp/leo_animated_lossy.webp"; | |||
| public const string AnimatedIssue2528 = "Webp/issues/issue2528.webp"; | |||
There was a problem hiding this comment.
Maybe fa4febf has to be reverted now?
There was a problem hiding this comment.
yeah I think you are right. We should squash commits when merging this, because of the back and forth here
JimBobSquarePants
approved these changes
Oct 13, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Adds a flag to decide how to handle the background color Animation Chunk.
The specification is vague on how to handle the background color of the animation chunk.
This option let's the user choose how to deal with it.
Related Issue: #2528