Fix DrawImage offsetting issues and improve API parameter names. #2474
Conversation
JimBobSquarePants
requested review from
tocsoft,
antonfirsov,
dlemstra and
brianpopow
There was a problem hiding this comment.
this is is quite alot of breaking changes..
we have 2 dfferent types of breakign changes happening here, we have the paramater name renames, which is a source breaking change for people using names paramaters.
And then we have the contructor change, which is both a source and binary breaking change.
I am a little less opiniated with regards the source/paramater rename break. i'm not really a fan of breaking them for not a lot of benefit but i can live with them. but we really should not be introducing the binary break.
| /// <param name="colorBlendingMode">The blending mode to use when drawing the image.</param> | ||
| /// <param name="alphaCompositionMode">The Alpha blending mode to use when drawing the image.</param> | ||
| /// <param name="opacity">The opacity of the image to blend.</param> | ||
| public DrawImageProcessor( | ||
| Image image, | ||
| Point location, | ||
| Point backgroundLocation, |
There was a problem hiding this comment.
we should add an overload with out the ForegroundRectangle for back compatability, as this will be an binary breaking change.
There was a problem hiding this comment.
I always forget these are public.
Thanks, and very much noted. I only changed them because I actually got confused while debugging. I'd like to keep them for v3.1 as I feel they do add benefit. |
Prerequisites
Description
Fixes #2447
In addition, I renamed the parameters and properties in the extension methods and processors to make it obvious what each thing means.