Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use System.Half for HalfTypeHelper #2233

Merged
merged 4 commits into from
Sep 16, 2022
Merged

Use System.Half for HalfTypeHelper #2233

merged 4 commits into from
Sep 16, 2022

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Replaces our incredibly complex custom packing code with System.Half plus casting.

@JimBobSquarePants JimBobSquarePants added this to the 3.0.0 milestone Sep 16, 2022
brianpopow
brianpopow approved these changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@brianpopow brianpopow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now 👍

@JimBobSquarePants JimBobSquarePants merged commit 22a7cba into main Sep 16, 2022
@JimBobSquarePants JimBobSquarePants deleted the js/system-half branch September 16, 2022 12:29
@teo-tsirpanis teo-tsirpanis mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teo-tsirpanis teo-tsirpanis teo-tsirpanis left review comments

@tannergooding tannergooding tannergooding left review comments

@brianpopow brianpopow brianpopow approved these changes

@antonfirsov antonfirsov Awaiting requested review from antonfirsov

@dlemstra dlemstra Awaiting requested review from dlemstra

@tocsoft tocsoft Awaiting requested review from tocsoft

Assignees
No one assigned
Labels
area:pixelformats codequality
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@JimBobSquarePants @tannergooding @teo-tsirpanis @brianpopow