Add TryGetLinearlySeparableComponents and tests #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimBobSquarePants
requested review from
antonfirsov,
brianpopow,
dlemstra and
tocsoft
|
Ooh I forgot about this branch, really happy to see it back! |
|
Very useful!! I'll be incorporating it into the general convolution API I'll be exposing. |
antonfirsov
reviewed
Sep 26, 2022
|
|
||
| for (int x = 1; x < width; x++) | ||
| { | ||
| if (Math.Abs(ratio - (matrix[y, x] / matrix[0, x])) > 0.0001f) |
There was a problem hiding this comment.
Using a hardcoded epsilon might be problematic in many cases. Personally I prefer to make it a parameter with a default value or at least to work with library-wide constants proven to work well for the given library.
What are ImageSharp use-cases for this feature?
There was a problem hiding this comment.
Yeah we should normalise constants. There might be one in Numerics already.
I plan to use this as an underlying optimisation when exposing a general convolution API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This is all @Sergio0694 brilliant work from sp/auto-matrix-linear-decomposition. All I've done is copy the code and tests from that branch as it's impossible to merge it following the Git LFS changes.