Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BenchmarkDotNet config obsolete method usage fix #2042

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

br3aker
Copy link
Contributor

@br3aker br3aker commented Mar 6, 2022

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Replaced obsolete API.

Obsolete method calls a new one so this should be good to just replace them:

[EditorBrowsable(EditorBrowsableState.Never)]
[Obsolete("This method will soon be removed, please start using ..WithArguments() instead")]
public static Job With(this Job job, IReadOnlyList<Argument> arguments)
{
    return job.WithArguments(arguments);
}

public static Job WithArguments(this Job job, IReadOnlyList<Argument> arguments)
{
    return job.WithCore(delegate (Job j)
    {
        j.Infrastructure.Arguments = arguments;
    });
}

@JimBobSquarePants
Copy link
Member

Thanks. Kept seeing these and meaning to fix them

@JimBobSquarePants JimBobSquarePants merged commit 1859d0f into SixLabors:main Mar 7, 2022
@br3aker br3aker deleted the dp/benchmark-warning branch March 7, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants