PixelOperations<TPixel>.From<RgbaVector> speedup #1435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
When using any of the generic
Image.CloneAs<TPixel>
APIs, if the target format wasRgbaVector
, the selected code paths was not optimized to take advantage of the fact thatRgbaVector
is blittable toVector4
. In particular, thisPixelOperations<TPixel>.To
method was called:ImageSharp/src/ImageSharp/PixelFormats/PixelOperations{TPixel}.cs
Lines 103 to 134 in 521fae3
You can see the method is virtual but was not overridden by
RgbaVector
, so this slower implementation was used, which required both chunking of the target span as well as doing an extra copy to a temporary buffer. This PR adds a new override for this method toPixelOperations<RgbaVector>
that simply does a directToVector4
copy on the reinterpreted target span.