Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bokeh blur constructor tweaks (input validation, tiny speedup) #1332

Merged
merged 3 commits into from
Aug 31, 2020
Merged

Bokeh blur constructor tweaks (input validation, tiny speedup) #1332

merged 3 commits into from
Aug 31, 2020

Conversation

Sergio0694
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR does two things:

  • Adds missing input validation for the blur radius and number of components (with tests)
  • Reduces the overhead of the default constructor and skips the input validation there

antonfirsov
antonfirsov approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonfirsov antonfirsov merged commit 9b9e134 into master Aug 31, 2020
@antonfirsov antonfirsov deleted the sp/bokeh-blur-init-tweaks branch August 31, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonfirsov antonfirsov antonfirsov approved these changes

Assignees
No one assigned
Labels
area:performance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sergio0694 @antonfirsov