Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all dependency references. #1262

Merged
merged 10 commits into from
Jul 16, 2020
Merged

Update all dependency references. #1262

merged 10 commits into from
Jul 16, 2020

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Just a simple update to all reference dependencies. Might help with any .NET FX type forwarding issues

@JimBobSquarePants JimBobSquarePants added this to the 1.0.0 milestone Jul 7, 2020
@JimBobSquarePants
Copy link
Member Author

No idea what or why this is happening. Can get the tests to run locally without crashing either because ImageMagick decoder always crashes

https://github.com/SixLabors/ImageSharp/runs/845593121?check_suite_focus=true#step:7:97

@JimBobSquarePants
Copy link
Member Author

@antonfirsov I think we need to reevaluate our usage of RemoteExecutor to workaround some of the flakiness.

https://github.com/SixLabors/ImageSharp/runs/859311527?check_suite_focus=true#step:7:195

It does look like there's a way with Xunit to run code once at startup which would mean we could move it out of static contructors.
https://stackoverflow.com/a/53143426/427899

@antonfirsov
Copy link
Member

antonfirsov commented Jul 12, 2020

@JimBobSquarePants the last test failure I see is because of Magic.NET. What if we revert updating that, and address it in a separate PR?

I like the TestFramework trick.

@antonfirsov
Copy link
Member

Since it's a test-only change, I don't see a point to keep the 1.0 milestone.

@antonfirsov antonfirsov modified the milestones: 1.0.0, Future Jul 16, 2020
@JimBobSquarePants
Copy link
Member Author

I was going to update the .NET references also. I'll have one last crack in a mo but if that fails I'll scrap it.

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #1262 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1262   +/-   ##
=======================================
  Coverage   82.68%   82.68%           
=======================================
  Files         697      697           
  Lines       30589    30589           
  Branches     3460     3460           
=======================================
  Hits        25294    25294           
  Misses       4593     4593           
  Partials      702      702           
Flag Coverage Δ
#unittests 82.68% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd4835f...83b6330. Read the comment docs.

@JimBobSquarePants
Copy link
Member Author

@antonfirsov Turns out System.Memory is the trigger. I've updated all other .NET dependencies.

@JimBobSquarePants
Copy link
Member Author

I'm just gonna go ahead and merge this now since there are no code changes.

@JimBobSquarePants JimBobSquarePants merged commit 7ee0207 into master Jul 16, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/deps branch July 16, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants