Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async version of DiscoverDecoder #1260

Merged
merged 3 commits into from
Jul 7, 2020

Conversation

pekspro
Copy link
Contributor

@pekspro pekspro commented Jul 6, 2020

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

It was no async version of DiscoverDecoder, so I added DiscoverDecoderAsync. Since async methods can’t have out parameters, I return a tuple instead. I would not mind doing the same change on DiscoverDecoder so they look the same.

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #1260 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1260   +/-   ##
=======================================
  Coverage   82.60%   82.61%           
=======================================
  Files         697      697           
  Lines       30521    30529    +8     
  Branches     3444     3445    +1     
=======================================
+ Hits        25213    25221    +8     
  Misses       4603     4603           
  Partials      705      705           
Flag Coverage Δ
#unittests 82.61% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
src/ImageSharp/Image.Decode.cs 88.33% <100.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a48355...343b609. Read the comment docs.

@JimBobSquarePants
Copy link
Member

Thanks for this @pekspro I think simply transitioning the code internally as you have done is enough coverage for now.

I would not mind doing the same change on DiscoverDecoder so they look the same.

We've an established pattern using out parameters on the synchronous versions of our APIs that I do not want to change.

@JimBobSquarePants JimBobSquarePants added this to the 1.0.0 milestone Jul 7, 2020
@JimBobSquarePants JimBobSquarePants merged commit c0594f7 into SixLabors:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants