-
-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Adler32 to correctly filter intrinsics. #1229
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
// Copyright (c) Six Labors. | ||
// Licensed under the Apache License, Version 2.0. | ||
|
||
namespace SixLabors.ImageSharp.Tests | ||
{ | ||
public static partial class TestEnvironment | ||
{ | ||
internal static class Features | ||
{ | ||
public const string On = "1"; | ||
public const string Off = "0"; | ||
|
||
public const string EnableAES = "COMPlus_EnableAES"; | ||
public const string EnableAVX = "COMPlus_EnableAVX"; | ||
public const string EnableAVX2 = "COMPlus_EnableAVX2"; | ||
public const string EnableBMI1 = "COMPlus_EnableBMI1"; | ||
public const string EnableBMI2 = "COMPlus_EnableBMI2"; | ||
public const string EnableFMA = "COMPlus_EnableFMA"; | ||
public const string EnableHWIntrinsic = "COMPlus_EnableHWIntrinsic"; | ||
public const string EnableIncompleteISAClass = "COMPlus_EnableIncompleteISAClass"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one isn't a production switch. For the others, there is a rough hierarchy they follow:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The hierarchy basically means disabling SSE ( There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah lovely. I'll reference that. I intend on doing more intrinsics work in the near future. |
||
public const string EnableLZCNT = "COMPlus_EnableLZCNT"; | ||
public const string EnablePCLMULQDQ = "COMPlus_EnablePCLMULQDQ"; | ||
public const string EnablePOPCNT = "COMPlus_EnablePOPCNT"; | ||
public const string EnableSSE = "COMPlus_EnableSSE"; | ||
public const string EnableSSE2 = "COMPlus_EnableSSE2"; | ||
public const string EnableSSE3 = "COMPlus_EnableSSE3"; | ||
public const string EnableSSE3_4 = "COMPlus_EnableSSE3_4"; | ||
public const string EnableSSE41 = "COMPlus_EnableSSE41"; | ||
public const string EnableSSE42 = "COMPlus_EnableSSE42"; | ||
public const string EnableSSSE3 = "COMPlus_EnableSSSE3"; | ||
public const string FeatureSIMD = "COMPlus_FeatureSIMD"; | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also rename
CalculateSse
toCalculateSsse
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say no. It’s still an iteration of SSE technology.