Only throw for multi SOF when fully decoding. #1226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fix #1221
This image could be fully decoded but threw a multi-SOF frame error when decoding. There's something funky with the image as JpegSnoop struggled with it, complaining of data past the EOF marker so it's likely Identify somehow missed the marker.
Returning instead of throwing when decoding metadata only is a quick fix. This is the first issue of it's type so if it happens again we can attempt a more complicated fix.