Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete PngTextProperties from png metadata #1189

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Removed obsolete PngTextProperties, TextData Property should be used instead.

@brianpopow brianpopow added this to the 1.0.0-rc1 milestone Apr 27, 2020
@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #1189 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1189      +/-   ##
==========================================
+ Coverage   82.53%   82.55%   +0.01%     
==========================================
  Files         692      692              
  Lines       29983    29976       -7     
  Branches     3390     3388       -2     
==========================================
  Hits        24746    24746              
+ Misses       4540     4533       -7     
  Partials      697      697              
Flag Coverage Δ
#unittests 82.55% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
src/ImageSharp/Formats/Png/PngMetadata.cs 100.00% <ø> (+21.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6122df...6545bbd. Read the comment docs.

@brianpopow brianpopow merged commit 5639bab into master Apr 27, 2020
@brianpopow brianpopow deleted the bp/remObsoleteTxtProperty branch April 27, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants