-
-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring and tweaks (2) #1122
Conversation
This reverts commit 85de14f.
Codecov Report
@@ Coverage Diff @@
## master #1122 +/- ##
==========================================
- Coverage 82.31% 82.15% -0.16%
==========================================
Files 678 686 +8
Lines 28941 29048 +107
Branches 3270 3308 +38
==========================================
+ Hits 23822 23864 +42
- Misses 4427 4485 +58
- Partials 692 699 +7
Continue to review full report at Codecov.
|
This reverts commit 7de9a2d.
I think we should get this one finished and merged asap. The longer it hangs around the more conflicts it will have to cope with. |
@JimBobSquarePants This PR should be good to go, I've already made all the necessary changes we had discussed. I was really only waiting for the CI to come back to life so I could verify all the tests from here, but other then that it should be ok. |
Codecov Report
@@ Coverage Diff @@
## master #1122 +/- ##
==========================================
- Coverage 82.31% 82.15% -0.16%
==========================================
Files 678 686 +8
Lines 28941 29048 +107
Branches 3270 3308 +38
==========================================
+ Hits 23822 23864 +42
- Misses 4427 4485 +58
- Partials 692 699 +7
Continue to review full report at Codecov.
|
I will review the PR in the evening. Those |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, all changes are trivial. I will keep kicking the CI until the build succeeds, after that we can merge.
Fixes #1111.
Follow up from the (failed) #1120.
Prerequisites
Description
struct
constraints to unmanaged (eg. inwhere TPixel : unmanaged, IPixel<TPixel>
, instead of the previouswhere TPixel : struct, IPixel<TPixel>
)struct
-s, or at least all the various method/property getters/etc. asreadonly
as possible (this is more expressive and avoids safety copies by the compiler)