Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge SixLabors.Core sources into ImageSharp #1087

Merged
merged 170 commits into from
Jan 20, 2020
Merged

Conversation

antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Jan 20, 2020

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Redo #1086: Merge sources and tests from SixLabors.Core, resolve #1002.

tocsoft and others added 30 commits June 2, 2017 21:55
doing this to be consistent with System.Drawing.Primitives
…add-guards

Added guards from the ImageSharp project
@antonfirsov
Copy link
Member Author

Helper tests were left out this time, opened SixLabors/SharedInfrastructure#5 instead.

@antonfirsov antonfirsov requested a review from a team January 20, 2020 00:39
@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #1087 into master will increase coverage by 0.05%.
The diff coverage is 87.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1087      +/-   ##
==========================================
+ Coverage   83.71%   83.77%   +0.05%     
==========================================
  Files         688      704      +16     
  Lines       28853    29311     +458     
==========================================
+ Hits        24155    24555     +400     
- Misses       4698     4756      +58
Flag Coverage Δ
#unittests 83.77% <87.33%> (+0.05%) ⬆️
Impacted Files Coverage Δ
src/ImageSharp/Memory/BufferArea{T}.cs 97.05% <ø> (ø) ⬆️
...ing/Processors/Transforms/CropProcessor{TPixel}.cs 100% <ø> (ø) ⬆️
...s/Convolution/Convolution2PassProcessor{TPixel}.cs 84% <ø> (ø) ⬆️
...ng/Processors/Overlays/BackgroundColorProcessor.cs 100% <ø> (ø) ⬆️
...sors/Binarization/BinaryErrorDiffusionProcessor.cs 88.23% <ø> (ø) ⬆️
...cessing/Processors/Convolution/PrewittProcessor.cs 100% <ø> (ø) ⬆️
...mageSharp/Processing/ProjectiveTransformBuilder.cs 81.39% <ø> (ø) ⬆️
...g/Processors/Filters/LomographProcessor{TPixel}.cs 100% <ø> (ø) ⬆️
...cessing/Processors/Convolution/BoxBlurProcessor.cs 100% <ø> (ø) ⬆️
...ssors/Binarization/BinaryOrderedDitherProcessor.cs 100% <ø> (ø) ⬆️
... and 260 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3ecd89...815aeb1. Read the comment docs.

@JimBobSquarePants
Copy link
Member

Looks great, well done!

I added the namespace changes in this PR as I need to unblock the version updates to the dependent libraries.

@JimBobSquarePants JimBobSquarePants merged commit 4973f5f into master Jan 20, 2020
@JimBobSquarePants JimBobSquarePants deleted the af/merge-core-2 branch January 20, 2020 10:28
@JimBobSquarePants JimBobSquarePants added this to the 1.0.0-rc1 milestone Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Externalize ImageSharp.Drawing
7 participants