Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid Subsampling checks. #1078

Merged
merged 3 commits into from
Jan 10, 2020
Merged

Remove invalid Subsampling checks. #1078

merged 3 commits into from
Jan 10, 2020

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Removed the upper range checks for XY subsampling values in the SOF frame marker.

These must have been left over from before @antonfirsov normalized the upsampling algorithm which seems to work well with everything.

In addition, one of our previously unrecoverable images now no longer crashes and produces (incorrect compared to unfuzzed input, but expected) an output image.

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@0c043e1). Click here to learn what that means.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1078   +/-   ##
=========================================
  Coverage          ?   89.83%           
=========================================
  Files             ?     1200           
  Lines             ?    53010           
  Branches          ?     3844           
=========================================
  Hits              ?    47624           
  Misses            ?     4560           
  Partials          ?      826
Impacted Files Coverage Δ
tests/ImageSharp.Tests/TestImages.cs 100% <ø> (ø)
src/ImageSharp/Formats/Bmp/BmpDecoderCore.cs 94.21% <ø> (ø)
src/ImageSharp/Formats/Bmp/BmpEncoderCore.cs 95.33% <ø> (ø)
src/ImageSharp/Formats/Tga/TgaDecoderCore.cs 88.1% <ø> (ø)
src/ImageSharp/Formats/Gif/LzwDecoder.cs 92.94% <ø> (ø)
src/ImageSharp/Formats/Tga/TgaEncoderCore.cs 98.51% <ø> (ø)
...Sharp.Tests/Formats/Jpg/JpegDecoderTests.Images.cs 100% <100%> (ø)
...c/ImageSharp/Common/Extensions/StreamExtensions.cs 93.33% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c043e1...cab0e59. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit 98a99d5 into master Jan 10, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/fix-1076 branch January 10, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants