Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIFF with circular IFD list #1891

Closed
4 tasks done
brianpopow opened this issue Dec 13, 2021 · 0 comments · Fixed by #1892
Closed
4 tasks done

TIFF with circular IFD list #1891

brianpopow opened this issue Dec 13, 2021 · 0 comments · Fixed by #1892
Labels
bug formats:tiff

Comments

@brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of ImageSharp
  • I have verified if the problem exist in both DEBUG and RELEASE mode
  • I have searched open and closed issues to ensure it has not already been reported

Description

As pointed out in bugzilla-BugReport, it is possible to create invalid tiff files with circular IFD directories. We should fix it the same way as libtiff did and limit the number of directories to read: https://gitlab.com/libtiff/libtiff/-/commit/473851d211cf8805a161820337ca74cc9615d6ef

Steps to Reproduce

Use the following tiff file:
libtiff_4-0-9_tiff2pdf_uncontrolled-resource-consumption_TIFFSetDirectory.zip

System Configuration

  • ImageSharp version: current master branch
  • Environment (Operating system, version and so on): all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug formats:tiff
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tiff: Add maximum IFD threshold SixLabors/ImageSharp
1 participant
@brianpopow