Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PngDecoder should not throw when encountering invalid Zlib data for non critical chunks. #1004

Closed
4 tasks done
JimBobSquarePants opened this issue Sep 8, 2019 · 0 comments · Fixed by #1005
Closed
4 tasks done

PngDecoder should not throw when encountering invalid Zlib data for non critical chunks. #1004

JimBobSquarePants opened this issue Sep 8, 2019 · 0 comments · Fixed by #1005
Assignees
@JimBobSquarePants
Labels
bug formats:png
Milestone
1.0.0-rc1

Comments

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of ImageSharp
  • I have verified if the problem exist in both DEBUG and RELEASE mode
  • I have searched open and closed issues to ensure it has not already been reported

Description

The following image will cause our decoder to throw due to an invalid Zlib data contained within the zTxt chunk. While correct, this chunk is non-critical and will be ignored during decoding by libpng and System.Drawing.

versioning-1_1

Steps to Reproduce

System Configuration

  • ImageSharp version:
  • Other ImageSharp packages and versions: 1.0.0-beta0007
  • Environment (Operating system, version and so on): All
  • .NET Framework version: All
  • Additional information:
@JimBobSquarePants JimBobSquarePants self-assigned this Sep 8, 2019
@JimBobSquarePants JimBobSquarePants added this to the 1.0.0-rc1 milestone Sep 8, 2019
JimBobSquarePants added a commit that referenced this issue Sep 8, 2019
@JimBobSquarePants
Fix #1004
dbc5c76
@JimBobSquarePants JimBobSquarePants mentioned this issue Sep 8, 2019
Merged
4 tasks
JimBobSquarePants added a commit that referenced this issue Sep 11, 2019
@JimBobSquarePants
Merge pull request #1005 from SixLabors/issue/1004
5b73284 
Fix #1004
antonfirsov pushed a commit to antonfirsov/ImageSharp that referenced this issue Nov 11, 2019
@JimBobSquarePants
Fix SixLabors#1004
c9cd1cd
antonfirsov pushed a commit to antonfirsov/ImageSharp that referenced this issue Nov 11, 2019
@JimBobSquarePants
Merge pull request SixLabors#1005 from SixLabors/issue/1004
62dd62f 
Fix SixLabors#1004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JimBobSquarePants JimBobSquarePants

Labels
bug formats:png
Projects
None yet
Milestone
1.0.0-rc1
Development

Successfully merging a pull request may close this issue.

Fix #1004 SixLabors/ImageSharp
1 participant
@JimBobSquarePants