[sitecore-jss-nextjs] Refactor RedirectsMiddleware for Better Extensibility #2040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
RedirectsMiddleware
class to improve its extensibility and maintainability by:getExistsRedirect
protected to allow override in derived classesDescription / Motivation
Extending
RedirectsMiddleware
orMiddlewareBase
currently requires re-implementing the entire handler. ChanginggetExistsRedirect
to a protected method and encapsulating the handler will make it easier to extendRedirectsMiddleware
and add optimizations like caching or logic to bypass fetches to Sitecore under certain criteria.This PR makes the following changes:
processRedirectRequest
that encapsulates the core redirect logicgetExistsRedirect
access modifier fromprivate
toprotected
processRedirectRequest
Testing Details
Existing functionality in
RedirectsMiddleware
remains the same. These changes were tested in both development and production deployed applications on Vercel.Types of changes