Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ms 861 fix bug in module downsync when moves are involved #1076

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Ms 861 fix bug in module downsync when moves are involved #1076

wants to merge 2 commits into from

Conversation

BurningAXE
Copy link
Contributor

@BurningAXE BurningAXE commented Jan 29, 2025 •
edited
Loading

This is the simple fix that touches the least amount of code and leaves the complexity as is.
Check out #1077 for the refactored version.

Pros

  • Lessens risk that we break something now

Cons

  • Increases risk we break something in the future
  • Code remains complex and hard to reason about

@cla-bot cla-bot bot added the ... label Jan 29, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
73.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@BurningAXE BurningAXE mentioned this pull request Jan 29, 2025
Open
@BurningAXE BurningAXE requested review from a team, luhmirin-s, alex-vt, meladRaouf, TristramN, ybourgery and alexandr-simprints and removed request for a team January 29, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhmirin-s luhmirin-s Awaiting requested review from luhmirin-s luhmirin-s was automatically assigned from Simprints/sid-reviewers

@alex-vt alex-vt Awaiting requested review from alex-vt alex-vt was automatically assigned from Simprints/sid-reviewers

@meladRaouf meladRaouf Awaiting requested review from meladRaouf meladRaouf was automatically assigned from Simprints/sid-reviewers

@TristramN TristramN Awaiting requested review from TristramN TristramN was automatically assigned from Simprints/sid-reviewers

@ybourgery ybourgery Awaiting requested review from ybourgery ybourgery was automatically assigned from Simprints/sid-reviewers

@alexandr-simprints alexandr-simprints Awaiting requested review from alexandr-simprints alexandr-simprints was automatically assigned from Simprints/sid-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BurningAXE