Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Air Alarm Pressure Thresholds #996

Merged
merged 6 commits into from
Oct 19, 2024

Conversation

zelezniciar1
Copy link
Contributor

@zelezniciar1 zelezniciar1 commented Oct 1, 2024

Description

  • Adjusts the "danger" status threshold in Air Alarms to 20 kPa, resulting in "warning" status at the expected 90 kPa.
  • Fixes the issue where air alarms had "danger" status at 20 kPa and "warning" status at 21 kPa

Changelog

🆑 zelezniciar

  • fix: Fixes Air Alarms not entering danger/warning state when pressure is low

@github-actions github-actions bot added the Changes: YML Changes any yml files label Oct 1, 2024
@SimpleStation14 SimpleStation14 changed the title Adjust Air Alarm pressure thresholds Adjust Air Alarm Pressure Thresholds Oct 1, 2024
@Mnemotechnician
Copy link
Contributor

This is intentional, you do NOT want firelocks to bolt at 85 kpa.

@zelezniciar1
Copy link
Contributor Author

It could be set lower, but doesn't being under 85 kPa mean that internals are needed, therefore, it's no longer safe?

@Mnemotechnician
Copy link
Contributor

that's what warning is for

@FoxxoTrystan FoxxoTrystan requested review from a team, VMSolidus, FoxxoTrystan, DEATHB4DEFEAT, Peptide90, Pspritechologist and OldDanceJacket and removed request for a team October 1, 2024 21:44
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Oct 1, 2024
@FoxxoTrystan FoxxoTrystan added Priority: 3-Medium Needs to be resolved at some point Size: 5-Very Small For especially small issues/PRs Status: Needs Discussion Must be discussed labels Oct 1, 2024
@FoxxoTrystan
Copy link
Contributor

A thing i wana note is again the airalarm go in warning state IF the air is not NORMAL.

That is a warning.

@zelezniciar1
Copy link
Contributor Author

zelezniciar1 commented Oct 1, 2024

Alright, I've altered it so 0-20 kPa is "danger" status, and 20-90 kPa is "warning"

@DEATHB4DEFEAT DEATHB4DEFEAT merged commit fce71cd into Simple-Station:master Oct 19, 2024
12 checks passed
DangerRevolution pushed a commit to DangerRevolution/Einstein-Engines that referenced this pull request Oct 19, 2024
@zelezniciar1 zelezniciar1 deleted the alarm-threshold branch October 21, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 5-Very Small For especially small issues/PRs Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants