Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-Pick PR26540: "Fix Empty Atmos Deserialization" #558

Merged

Conversation

VMSolidus
Copy link
Member

Description

Cherry-Picks Wizden PR 26540, fixing an issue where our downstreams cannot save maps under certain conditions.

space-wizards/space-station-14#26540

@github-actions github-actions bot added the Changes: C# Changes any cs files label Jul 17, 2024
@DangerRevolution DangerRevolution changed the title Cherry-Pick PR26540 Cherry-Pick PR26540: "Fix empty atmos deserialization" Jul 17, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the PR in the title, why do I have to click it to know what it is

@SimpleStation14 SimpleStation14 changed the title Cherry-Pick PR26540: "Fix empty atmos deserialization" Cherry-Pick PR26540: "Fix Empty Atmos Deserialization" Jul 17, 2024
@DangerRevolution DangerRevolution merged commit 3bc5052 into Simple-Station:master Jul 17, 2024
13 checks passed
@DangerRevolution
Copy link
Contributor

Unless my GitHub isn't updating pretty sure it just let me merge with tests still running....

@DEATHB4DEFEAT
Copy link
Member

Unless my GitHub isn't updating pretty sure it just let me merge with tests still running....

Certain tests aren't technically required, but you should still wait for them to succeed.

@DangerRevolution
Copy link
Contributor

Unless my GitHub isn't updating pretty sure it just let me merge with tests still running....

Certain tests aren't technically required, but you should still wait for them to succeed.

It should repo ban you for merging without every test passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants