Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror: Code cleanup: puddles and spreaders #208

Closed
wants to merge 1 commit into from
Closed

Mirror: Code cleanup: puddles and spreaders #208

wants to merge 1 commit into from

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26102: Code cleanup: puddles and spreaders from space-wizards space-wizards/space-station-14

cf0da11eb791b78590b5a57b0a9ef8572217b7a6

PR opened by Tayrtahn at 2024-03-14 02:18:04 UTC

PR changed 6 files with 65 additions and 60 deletions.

The PR had the following labels:

Original Body

About the PR

Code cleanup and modernization for files related to puddles and other spreaders.

Why / Balance

Clean code is happy code.

Technical details

Replaced all obsolete method calls with appropriate entity system methods, and cleaned up a few other things.

In my testing, puddles, smoke, foam, and kudzu all seemed to work as expected, but I would definitely appreciate having some other people look this over.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

SpreadNeighborsEvent.NeighborFreeTiles is now ValueList<(MapGridComponent Grid, TileRef Tile)> instead of ValueList<(MapGridComponent Grid, Vector2i Tile)>

Changelog

Exciting stuff here, but no.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
DangerRevolution
DangerRevolution suggested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has no changes

@VMSolidus VMSolidus closed this Apr 30, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
@FoxxoTrystan
Merge pull request Simple-Station#208 from Memeji/Nikko-Species
003066d 
Rodentia Species
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
@Floof-Station-Bot
Automatic Changelog Update (Simple-Station#208)
5f95026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DangerRevolution DangerRevolution DangerRevolution requested changes

Assignees
No one assigned
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimpleStation14 @DangerRevolution @VMSolidus