Plantbot #1831
Merged
Plantbot #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timfa2112
requested review from
DEATHB4DEFEAT,
sleepyyapril and
Remuchi
as code owners
github-actions
bot
added
Changes: C#
sleepyyapril
previously requested changes
Feb 21, 2025
| private EntityLookupSystem _lookup = default!; | ||
| private PathfindingSystem _pathfinding = default!; | ||
|
|
||
| [DataField] public string RangeKey = NPCBlackboard.PlantbotServiceRange; |
There was a problem hiding this comment.
separate lines, add a summary
There was a problem hiding this comment.
(specifically the datafield)
There was a problem hiding this comment.
Applied in e0e7f87
...ver/NPC/HTN/PrimitiveTasks/Operators/Specific/PickNearbyServicableHydroponicsTrayOperator.cs
Outdated
Show resolved
Hide resolved
...ver/NPC/HTN/PrimitiveTasks/Operators/Specific/PickNearbyServicableHydroponicsTrayOperator.cs
Show resolved
Hide resolved
...ver/NPC/HTN/PrimitiveTasks/Operators/Specific/PickNearbyServicableHydroponicsTrayOperator.cs
Outdated
Show resolved
Hide resolved
Content.Server/NPC/HTN/PrimitiveTasks/Operators/Specific/PlantBotServiceOperator.cs
Show resolved
Hide resolved
Content.Server/NPC/HTN/PrimitiveTasks/Operators/Specific/PlantBotServiceOperator.cs
Show resolved
Hide resolved
Comment on lines
66
to
86
| { | ||
| _plantHolderSystem.AdjustWater(target, -10f); | ||
| _audio.PlayPvs(botComp.RemoveWaterSound, target); | ||
| } | ||
| else | ||
| { | ||
| if (plantHolderComponent.WaterLevel < 80f) | ||
| { | ||
| _plantHolderSystem.AdjustWater(target, 10); | ||
| _audio.PlayPvs(botComp.WaterSound, target); | ||
| _chat.TrySendInGameICMessage(owner, Loc.GetString("plantbot-add-water"), InGameICChatType.Speak, hideChat: true, hideLog: true); | ||
| } | ||
| else if (plantHolderComponent.WeedLevel > 1) | ||
| { | ||
| plantHolderComponent.WeedLevel -= 1; | ||
| _audio.PlayPvs(botComp.WeedSound, target); | ||
| _chat.TrySendInGameICMessage(owner, Loc.GetString("plantbot-remove-weeds"), InGameICChatType.Speak, hideChat: true, hideLog: true); | ||
| } | ||
| else | ||
| return HTNOperatorStatus.Failed; | ||
| } |
There was a problem hiding this comment.
use constants to make this easily readable
There was a problem hiding this comment.
Applied in e0e7f87
Part 1/2 Co-authored-by: sleepyyapril <[email protected]> Signed-off-by: Timfa <[email protected]>
|
Will merge if tests fine, ping in discord if ends up okay |
sleepyyapril
approved these changes
Feb 21, 2025
SimpleStation14
added a commit
that referenced
this pull request
Feb 21, 2025
|
Love this addition, but shouldn't it use a mini-hoe instead of clippers in it's recipe since it clears weeds and doesn't clip? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the Plantbot!
The Plantbot will help keep Hydroponics Trays filled with water and cleared of weeds.
It will add water in 10u steps if there is less than 80u in the tray, and will clear weeds with 10% per step if there are more than 10% weeds in the tray.
If the bot is destroyed, it will spill a bunch of water.
It does not add nutrients, sample, harvest or plant.
If emagged, it'll drink water from trays until no water remains.
Media
20250221135110.mp4
Changelog
🆑