Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamable Component #1821

Merged
merged 8 commits into from
Feb 21, 2025
Merged

Conversation

Timfa2112
Copy link
Contributor

@Timfa2112 Timfa2112 commented Feb 18, 2025

Description

Adds a component (added to MobSoliconBase) which allows you to rename an entity in-game via a verb.


TODO

  • Make the Verb appear
  • Successfully open the UI
  • Apply input as entity name

Media

Example Media Embed


Changelog

🆑

  • tweak: Allow renaming robots and pAI

Todo: Why doesn't the Verb appear??
@Timfa2112 Timfa2112 marked this pull request as draft February 18, 2025 20:40
@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files and removed Status: Needs Review Someone please review this labels Feb 18, 2025
Not applying the name yet, though
Still won't actually apply the name, but the function is being called and the user-input string is going in
@sleepyyapril
Copy link
Contributor

Doesn't this just do what can be done to borgs through opening their panel, the intended way? Should make this only apply to things like pAIs.

doesn't work yet
@Timfa2112
Copy link
Contributor Author

Doesn't this just do what can be done to borgs through opening their panel, the intended way? Should make this only apply to things like pAIs.

The robots are actually the primary objective, the pAI was a bonus. I'm making this in response to a poll on Goob MRP to see if people would like it.

What you're saying about Borgs is a good hint though, because as you say that bit does pretty much what I'm trying here. Next time I continue with this I'll have a good look at how that works :)

@Timfa2112 Timfa2112 marked this pull request as ready for review February 20, 2025 17:48
@Timfa2112
Copy link
Contributor Author

Should I also put this on buttons, levers, etc.? So people can describe a button's function?

@sleepyyapril
Copy link
Contributor

Should I also put this on buttons, levers, etc.? So people can describe a button's function?

Hand labeler does that part for you

Copy link
Contributor

@sleepyyapril sleepyyapril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exclude borgs from this. You do not need to change parenting, just check if they have a SiliconComponent and return on rename attempt if so.

@Timfa2112
Copy link
Contributor Author

Exclude borgs from this. You do not need to change parenting, just check if they have a SiliconComponent and return on rename attempt if so.

as mentioned in Discord, Borgs aren't affected. Apologies for the confusion!

Co-authored-by: sleepyyapril <[email protected]>
Signed-off-by: Timfa <[email protected]>
@Timfa2112
Copy link
Contributor Author

Tested and seems to work as intended :)

@sleepyyapril sleepyyapril merged commit 3014a0d into Simple-Station:master Feb 21, 2025
12 checks passed
SimpleStation14 added a commit that referenced this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants