Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiauth / SimpleStation RT #1696

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Multiauth / SimpleStation RT #1696

wants to merge 8 commits into from

Conversation

DEATHB4DEFEAT
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT commented Feb 1, 2025 •
edited
Loading

Description

Requires Simple-Station/SupermatterEngine#3

TODO

  • Find out if/why I should store the auth server someone uses
  • Allow linking accounts (another PR?)
  • Update things that use just usernames
    • OOC
    • Admin UIs
      • Bans
      • Notes
      • AHelp
      • Player lists

Media

image

image

image

image

Changelog

🆑

  • add: Players can now join with either Space Wizards' or SimpleStation accounts, and servers can choose to add/remove allowed auth servers via the auth.servers cvar

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Feb 1, 2025
@DEATHB4DEFEAT DEATHB4DEFEAT added Priority: 2-High Needs to be resolved as soon as possible Status: Do Not Merge Do not merge Status: Requires This requires something else to be done before being resolved Type: Codebase An issue with the codebase Type: Feature Creation of or significant changes to a feature Type: Rework Large changes to a system, like a mix between the Balancing, Codebase, and Respace labels labels Feb 1, 2025
@sleepyyapril
Copy link
Contributor

This will require a test of the launcher and all associated systems before merging so that we don't accidentally break everything.

@DEATHB4DEFEAT
Copy link
Member Author

This will require a test of the launcher and all associated systems before merging so that we don't accidentally break everything.

Yeah I'll probably run a Parkstation event.

@DEATHB4DEFEAT DEATHB4DEFEAT changed the title Multiauth Multiauth / SimpleStation RT Feb 12, 2025
@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Feb 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Changes: Sprite Changes any png or json in an RSI label Feb 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 23, 2025 •
edited
Loading

RSI Diff Bot; head commit c5228b1 merging into 321243e
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:
Edit: diff updated after c5228b1

@DEATHB4DEFEAT
Copy link
Member Author

Undrafting since it seems to work, and for tests, still DNM though.

@DEATHB4DEFEAT DEATHB4DEFEAT marked this pull request as ready for review February 23, 2025 01:26
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Feb 23, 2025
@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Feb 23, 2025
@github-actions github-actions bot added the Changes: Documentation Changes any xml or md files label Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurboTrackerss14 TurboTrackerss14 TurboTrackerss14 left review comments

@sleepyyapril sleepyyapril Awaiting requested review from sleepyyapril sleepyyapril is a code owner

@Remuchi Remuchi Awaiting requested review from Remuchi Remuchi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Priority: 2-High Needs to be resolved as soon as possible Status: Do Not Merge Do not merge Status: Needs Review Someone please review this Status: Requires This requires something else to be done before being resolved Type: Codebase An issue with the codebase Type: Feature Creation of or significant changes to a feature Type: Rework Large changes to a system, like a mix between the Balancing, Codebase, and Respace labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DEATHB4DEFEAT @sleepyyapril @TurboTrackerss14