Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newtonian Singularity #1619

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Conversation

VMSolidus
Copy link
Member

Description

By request from the very same person who assisted with #1618
This PR ports(and fixes) space-wizards/space-station-14#23372 such that it works on modern Robust Toolbox.

This PR essentially makes it so that the Singularity (And Tesla by extension) inherit some of the momentum of objects thrown into them. Im practice it means that they now work more like they do in SS13, whereby if a traitor does not actively intervene in a Singuloose(such as by using a Singularity Beacon), the singularity will usually be "Blown back into space" by space wind throwing objects at it in retaliation to it eating engineering.

Media

293695808-65887ee9-7783-4212-9421-81414978c7d1.mp4

Changelog

🆑

  • add: Singularity and Tesla are now affected by objects thrown into them, causing them to change directions. Unless a traitor intervenes (with a Singularity Beacon), a "Singuloose" is extremely likely to be blown out to space.

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: YML Changes any yml files and removed Status: Needs Review Someone please review this labels Jan 20, 2025
@DEATHB4DEFEAT
Copy link
Member

hilarious

@sleepyyapril
Copy link
Contributor

What's the perf cost of this? Anything substantial?

@DEATHB4DEFEAT
Copy link
Member

What's the perf cost of this? Anything substantial?

Most likely negligible

@VMSolidus
Copy link
Member Author

What's the perf cost of this? Anything substantial?

O(1) complexity, it's a minor amount of trivial math done on single entities at a time. So the cost is "Basically nonexistent".

Co-authored-by: DEATHB4DEFEAT <[email protected]>
Signed-off-by: VMSolidus <[email protected]>
@VMSolidus VMSolidus merged commit 34b55e1 into Simple-Station:master Jan 21, 2025
11 checks passed
SimpleStation14 added a commit that referenced this pull request Jan 21, 2025
Bruno469 pushed a commit to Bruno469/Einstein-Engines that referenced this pull request Feb 5, 2025
# Description

By request from the very same person who assisted with
Simple-Station#1618
This PR ports(and fixes)
space-wizards/space-station-14#23372 such that
it works on modern Robust Toolbox.

This PR essentially makes it so that the Singularity (And Tesla by
extension) inherit some of the momentum of objects thrown into them. Im
practice it means that they now work more like they do in SS13, whereby
if a traitor does not actively intervene in a Singuloose(such as by
using a Singularity Beacon), the singularity will usually be "Blown back
into space" by space wind throwing objects at it in retaliation to it
eating engineering.

<details><summary><h1>Media</h1></summary>
<p>


https://github.com/user-attachments/assets/04e9e5b9-d873-4425-b19a-b854b57db486

</p>
</details>

# Changelog

:cl:
- add: Singularity and Tesla are now affected by objects thrown into
them, causing them to change directions. Unless a traitor intervenes
(with a Singularity Beacon), a "Singuloose" is extremely likely to be
blown out to space.

---------

Signed-off-by: VMSolidus <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]>
Bruno469 pushed a commit to Bruno469/Einstein-Engines that referenced this pull request Feb 5, 2025
@VMSolidus VMSolidus mentioned this pull request Feb 21, 2025
sleepyyapril pushed a commit that referenced this pull request Feb 21, 2025
# Description

Makes the singulo stop quantum tunneling through its containment. If
this doesn't work and I'm still on vacation beating up nerds in the
woods, you need to revert this pr right here:
#1619

# Changelog

:cl:
- fix: Singularity shouldn't escape its containment anymore. If it's
still escaping containment, do me a favor and revert PR 1619 (Newtonian
Singularity)

---------

Co-authored-by: Partmedia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants