Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job Whitelist System #1093

Merged
merged 3 commits into from
Oct 19, 2024
Merged

Job Whitelist System #1093

merged 3 commits into from
Oct 19, 2024

Conversation

FoxxoTrystan
Copy link
Contributor

@FoxxoTrystan FoxxoTrystan commented Oct 18, 2024 •
edited
Loading

Description

This PR Port the following PRs: space-wizards/space-station-14#28085 and DeltaV-Station/Delta-v#1678

This adds a simple job whitelist system, DB Migration correctly done, tested and working so far.
Why now? i need it.

TODO

  • Job WhiteList
  • Working with current RequirementSystem
  • DeltaV - Job Whitelist Panel Port

Media

image
image

Changelog

🆑

  • add: Job Whitelist!

@FoxxoTrystan FoxxoTrystan added Priority: 3-Medium Needs to be resolved at some point Type: Port Brings something to here from another codebase labels Oct 18, 2024
@FoxxoTrystan FoxxoTrystan self-assigned this Oct 18, 2024
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files labels Oct 18, 2024
@FoxxoTrystan FoxxoTrystan marked this pull request as ready for review October 18, 2024 15:42
@FoxxoTrystan FoxxoTrystan requested review from a team, VMSolidus, DEATHB4DEFEAT, Peptide90, Pspritechologist and OldDanceJacket and removed request for a team October 18, 2024 15:42
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Oct 18, 2024
@FoxxoTrystan FoxxoTrystan added the Size: 3-Medium For medium issues/PRs label Oct 18, 2024
VMSolidus
VMSolidus approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright bet

@DEATHB4DEFEAT
Copy link
Member

I do not like how the whitelist panel looks

@FoxxoTrystan
Copy link
Contributor Author

I do not like how the whitelist panel looks

I dont do UI, i only ported it, you can also use console command to whitelist.

@FoxxoTrystan FoxxoTrystan mentioned this pull request Oct 19, 2024
Merged
3 tasks
@VMSolidus VMSolidus merged commit 21b7a82 into Simple-Station:master Oct 19, 2024
18 checks passed
Ichaie pushed a commit to Ichaie/Einstein-Engines that referenced this pull request Oct 20, 2024
@SimpleStation14
Automatic Changelog Update (Simple-Station#1093)
d7de808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VMSolidus VMSolidus VMSolidus approved these changes

@Peptide90 Peptide90 Peptide90 approved these changes

@DEATHB4DEFEAT DEATHB4DEFEAT Awaiting requested review from DEATHB4DEFEAT DEATHB4DEFEAT was automatically assigned from Simple-Station/ee-writers

@Pspritechologist Pspritechologist Awaiting requested review from Pspritechologist Pspritechologist was automatically assigned from Simple-Station/ee-writers

@OldDanceJacket OldDanceJacket Awaiting requested review from OldDanceJacket OldDanceJacket was automatically assigned from Simple-Station/ee-writers

Assignees

@FoxxoTrystan FoxxoTrystan

Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 3-Medium For medium issues/PRs Status: Needs Review Someone please review this Type: Port Brings something to here from another codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FoxxoTrystan @DEATHB4DEFEAT @VMSolidus @Peptide90