Feature/windows ramdisk try2

[rvaidya]

Not the cleanest of solutions but it works - limiting the check to the specific error message we get from node in this situation.

Could try to deduplicate repeated code in the realpath function but that might hurt readability.

[SimenB]

Do we need this?

[rvaidya]

Whoops, my auto eslint kept changing my functions into arrow functions so I added that to stop them.

[SimenB]

I'm fine with arrows all over

[SimenB]

But not eslint ignores

[rvaidya]

I'm not sure what minimum version of node you want to support but arrow functions were added a bit later.

I've resolved this in the latest commit.

[SimenB]

Node 4 is the lowest :)

[SimenB]

I think some sort of isWinRamDiskError makes sense, which just checks code (and has the comment) makes sense

[rvaidya]

I think some sort of isWinRamDiskError makes sense, which just checks code (and has the comment) makes sense

The problem in the realpath function is you don't know that you've run into the situation up front, as you're immediately returning a promise -- unless you want to add something like let isWinRamDiskError = err.errno === -4068 purely for clarity without changing the control flow.

Ignore this

[rvaidya]

This next commit uses recursion to dedupe the code

[aliaksandr-yermalayeu]

@rvaidya, is there any progress on this one ?

[aliaksandr-yermalayeu]

@SimenB, 2 months passed, and there is still no response from @rvaidya. Are you ok if I create another pull request?

[rvaidya]

My last commit works and is still waiting for review, there isn't anything more I can do on my end

[aliaksandr-yermalayeu]

Oh, I was under impression you didn't finalize the PR (it still has failing checks). Maybe I was wrong. @SimenB, could you please speed up the process from your side?

[aliaksandr-yermalayeu]

@SimenB, any news?

[aliaksandr-yermalayeu]

@SimenB, @rvaidya, would you take a look this PR?

[sergei-startsev]

@SimenB Is there a chance to merge this PR? The issue blocks Jest upgrade and we're forced to use version 23. v24 was published 6 month ago and v25 is coming soon, however the issue is still unresolved. I'd appreciate if you could comment it.

[rominator1983]

What would be neccessary to get this merged? Do you need any help on this? This stops me being able to use a RAM-disk (#35).

[SimenB]

I've published a v3 and deprecated it - all current releases of node supports fs.realpath.native now, so this module is no longer needed.

Jest 26 no longer depends on this module.