Skip to content
This repository has been archived by the owner on Jun 9, 2024. It is now read-only.

Add Helicone #81

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Add Helicone #81

merged 3 commits into from
Jul 10, 2023

Conversation

waynehamadi
Copy link
Contributor

Background

Changes

PR Quality Checklist

  • I have run the following commands against my code to ensure it passes our linters: 
    black .
isort .
mypy .
autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring --in-place agbenchmark

waynehamadi
waynehamadi commented Jul 10, 2023
View reviewed changes
agbenchmark/challenge.py
@@ -23,7 +24,7 @@ class Challenge(ABC):

@property
def data(self) -> ChallengeData:
file_path = f"{self.CHALLENGE_LOCATION}/data.json"
file_path = f"{CURRENT_DIRECTORY}/../{self.CHALLENGE_LOCATION}/data.json"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes the CI when not using the mocks

@SilenNaihin SilenNaihin merged commit 30ba515 into Significant-Gravitas:master Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SilenNaihin SilenNaihin SilenNaihin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waynehamadi @SilenNaihin