Skip to content
This repository has been archived by the owner on Jun 9, 2024. It is now read-only.

Add timeout to agbenchmark #215

Merged
merged 3 commits into from
Jul 30, 2023
Merged

Add timeout to agbenchmark #215

merged 3 commits into from
Jul 30, 2023

Conversation

waynehamadi
Copy link
Contributor

Background

Changes

Currently, it's timeing out but doesn't send the results to google drive and doesn't commit so we loose the data

solution : put a timeout in the command itself

PR Quality Checklist

  • I have run the following commands against my code to ensure it passes our linters:
    black . --exclude test.py
    isort .
    mypy .
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring --in-place agbenchmark

@waynehamadi waynehamadi merged commit 52b8d1a into master Jul 30, 2023
@waynehamadi waynehamadi deleted the add-timeout-to-agbenchmark branch July 30, 2023 01:36
@github-actions
Copy link

PR Analysis

  • 🎯 Main theme: Adding a timeout to the agbenchmark command to prevent loss of data
  • 📌 Type of PR: Bug fix
  • 🧪 Relevant tests added: No
  • Focused PR: Yes, the PR is focused as it addresses a specific issue of data loss due to timeouts and provides a clear solution for it. All changes in the PR are relevant to this issue.
  • 🔒 Security concerns: No, the changes made in this PR do not introduce any apparent security concerns.

PR Feedback

  • 💡 General PR suggestions: The PR is generally well-structured and addresses a specific issue. However, it would be beneficial to add tests to ensure the timeout works as expected and does not introduce new issues. Also, consider adding more context to the PR description about why a 25-minute timeout was chosen and if there are any potential implications of this choice.

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe [-c]: Modify the PR title and description based on the contents of the PR. To get the description as comment instead of modifying the PR description, include the '-c' option.
/improve: Suggest improvements to the code in the PR. These will be provided as pull request comments, ready to commit.
/ask <QUESTION>: Pose a question about the PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant