SeaTalk composite data: implementation with session #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latitude and longitude are updated at the same time.
Date and Time are updated at the same time.
|
STALK tests are now failing, you probably got a message about them? Please fix: make sure |
|
The tests failed because not compliant with the new 0x50 0x51 behaviour and because 0x54 and 0x56 have been disabled in order to prevent a misbehaviour. |
joabakk
suggested changes
Aug 20, 2019
|
No need to fix the commits, easy enough to use Github SquashAndMerge, since this can be just a single commit. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of 0x50, 0x51 (latitude, longitude) and 0x54, 0x56 (time, date) datagrams have been implemented using the session propagated by the Parser class.