Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert outstanding files to cp1252 #170

Open
wants to merge 1 commit into
base: Development
Choose a base branch
from

Conversation

moretrim
Copy link

@moretrim moretrim commented Dec 4, 2019

There were many UTF-8 encoded files still, this change converts them to
the cp1252 encoding that the game expects. For a couple files this only
changes some comments, but this also fixes some actual text bugs.

HFM/localisation/0000_minimod.csv is of note because it contained
UTF-8 mojibake that was not valid cp1252. Since the invalid key came
from base game files it was easy to restore it to the original
characters.


When reviewing this PR, make sure you are looking at the changes with the correct encoding. For instance if using the Github web interface, your browser is likely to pick UTF-8 or fallback to auto-detection (with unpredictable results).

An example of a text bug that this PR fixes:

utf8

which was caused by:

2084 = { secede_province = THIS change_province_name = "Lüderitzbucht" any_pop = { literacy = -0.99 } life_rating = 21 }
2086 = { secede_province = THIS change_province_name = "Keetmanshoop" any_pop = { literacy = -0.99 } life_rating = 25 }
2085 = { secede_province = THIS change_province_name = "Maltahöhe" any_pop = { literacy = -0.99 } life_rating = 25 }

There were many UTF-8 encoded files still, this change converts them to
the cp1252 encoding that the game expects. For a couple files this only
changes some comments, but this also fixes some actual text bugs.

`HFM/localisation/0000_minimod.csv` is of note because it contained
UTF-8 mojibake that was not valid cp1252. Since the invalid key came
from base game files it was easy to restore it to the original
characters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant