Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint #2880

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

golangci-lint #2880

wants to merge 3 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jun 7, 2022

We should use the canonical golangci-lint.

The go.yml, I am not totally sure what it does but it seems like more than linting, so I left it alone.

@faddat
Copy link
Contributor Author

faddat commented Jun 7, 2022

The reason for this change is that it actually catches things that the other test does not. We had a similar in counter on the cosmos SDK recently

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #2880 (941021a) into develop (19fe0ec) will not change coverage.
The diff coverage is n/a.

❗ Current head 941021a differs from pull request most recent head b5b2ddf. Consider uploading reports for the commit b5b2ddf to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2880   +/-   ##
========================================
  Coverage    38.98%   38.98%           
========================================
  Files          131      131           
  Lines        12263    12263           
========================================
  Hits          4781     4781           
  Misses        7169     7169           
  Partials       313      313           
Impacted Files Coverage Δ
app/app.go 88.11% <0.00%> (ø)
cmd/sifnoded/cmd/root.go 60.66% <0.00%> (ø)
x/oracle/keeper/keeper.go 80.00% <0.00%> (ø)
x/ethbridge/keeper/blacklist.go 65.30% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant