v2: Improve signature and nonce handling #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukechampine
force-pushed
the
flip-nonce
branch
from
c630fce to
e057384
Compare
lukechampine
force-pushed
the
flip-nonce
branch
from
92f3765 to
d7b7396
Compare
lukechampine
force-pushed
the
flip-nonce
branch
from
d7b7396 to
4057618
Compare
n8maninger
approved these changes
Feb 20, 2025
ChrisSchinnerl
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sia has historically hashed all signature messages with BLAKE2b (in addition to the SHA512 performed internally by Ed25519), but this is unnecessary. Furthermore, nonces were being reused in an unsafe manner that could leak plaintext relationships (though the encryption key itself remains safe). This PR addresses both issues by bumping the version to 3 and branching on the version within the handshake. I don't love this; the "right" way to introduce a new version is to create an entire new
v3package. But that felt like an egregious amount of duplicated code. I'm hoping that we can clean up this situation when we drop support for v1 post-hardfork.I'll try running a node with these changes to ensure that it can communicate with existing v2 muxes.