Retry formation transaction sets #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8maninger
force-pushed
the
nate/fix-rejections-for-partial-parents
branch
from
60d7b81 to
1786ae5
Compare
n8maninger
force-pushed
the
nate/fix-rejections-for-partial-parents
branch
from
1786ae5 to
07f172c
Compare
n8maninger
force-pushed
the
nate/fix-rejections-for-partial-parents
branch
from
07f172c to
376e7f9
Compare
n8maninger
requested review from
peterjan,
lukechampine and
ChrisSchinnerl
and removed request for
peterjan,
lukechampine and
ChrisSchinnerl
n8maninger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression where a transaction set cannot be rebroadcast if one of its parents is already confirmed causing otherwise valid contract formations to be rejected.
What's, effectively, happening now is:
ephemeralParent,formationTxn]ephemeralParentis confirmed, but for some reasonformationTxnis not.formationTxnis technically still valid, butAddPoolTransactionsfails with "siacoin input 0 spends nonexistent siacoin output" sinceephemeralParentis already confirmedThe additional lifecycle test confirms this behavior