Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove application/graphql as a content type header #379

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Remove application/graphql as a content type header #379

merged 1 commit into from
Oct 25, 2024

Conversation

lizkenyon
Copy link
Contributor

WHY are these changes introduced?

  • We should have always been sending the application/json as the content type.
  • This will help us remain GraphQL spec compliant.

WHAT is this pull request doing?

  • Removes sending the application/graphql as the Content-type header

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have updated the documentation for public APIs from the library (if applicable)

@lizkenyon lizkenyon force-pushed the liz/update-content-type-header branch from db54dfa to 83c49bf Compare October 23, 2024 15:52
@lizkenyon lizkenyon requested a review from a team October 23, 2024 16:00
Arkham
Arkham approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@Arkham Arkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizkenyon lizkenyon merged commit 3d5be67 into main Oct 25, 2024
7 checks passed
@lizkenyon lizkenyon deleted the liz/update-content-type-header branch October 25, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkham Arkham Arkham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lizkenyon @Arkham