Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code and tests for the newest version of php-jwt #186

Merged
merged 7 commits into from
Nov 7, 2022

Conversation

uliandim
Copy link
Contributor

@uliandim uliandim commented Jun 7, 2022

WHY are these changes introduced?

Because of the vulnerabilities in the older version of php-jwt

https://snyk.io/vuln/composer:firebase%2Fphp-jwt

WHAT is this pull request doing?

Type of change

  • Major: Vulnerability fix

Checklist

  • Updated the composer.json file
  • Fixed tests
  • Small fix in the decode method

@uliandim uliandim requested a review from a team as a code owner June 7, 2022 21:21
@hSATAC
Copy link

hSATAC commented Oct 12, 2022

+1 to this.

@ConstantBqt
Copy link

+1 to this vulnerability fix

@Mattin
Copy link

Mattin commented Oct 18, 2022

+1 is this repository maintained anymore? 4 months nobody here to click accept...

@uliandim
Copy link
Contributor Author

Rebased with main, made additional tests fixes, CLA signed. Waiting for an approval 🤷‍♂️

@OwenMelbz
Copy link

+99999999999999

@crumb1e
Copy link

crumb1e commented Nov 4, 2022

+1, please can this be merged!

@ConstantBqt
Copy link

The code is not reviewed by learn-libs-superteam. Could we add paulomarg or teddyhwang as reviewers ?

@uliandim
Copy link
Contributor Author

uliandim commented Nov 5, 2022

The code is not reviewed by learn-libs-superteam. Could we add paulomarg or teddyhwang as reviewers ?

I cannot add them because learn-libs-superteam is the the code owner and this can be the only reviewer :(

@ConstantBqt
Copy link

The code is not reviewed by learn-libs-superteam. Could we add paulomarg or teddyhwang as reviewers ?

I cannot add them because learn-libs-superteam is the the code owner and this can be the only reviewer :(

Hi @paulomarg and @teddyhwang,
Could you please review this request ?

Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi folks, sorry for the delay. We appreciate the contribution!

@paulomarg paulomarg merged commit 26e75c2 into Shopify:main Nov 7, 2022
@uliandim
Copy link
Contributor Author

uliandim commented Nov 7, 2022

@paulomarg can you please bump the version also?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants