Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PHP 8.1 and drop 7.3 #134

Merged
merged 2 commits into from
Feb 16, 2022
Merged

Add support for PHP 8.1 and drop 7.3 #134

merged 2 commits into from
Feb 16, 2022

Conversation

paulomarg
Copy link
Contributor

PHP 7.3 has reached EOL, and 8.1 is released, so we should update our supported versions.

@paulomarg paulomarg requested a review from a team as a code owner February 8, 2022 16:24
teddyhwang
teddyhwang approved these changes Feb 16, 2022
View reviewed changes
Copy link
Collaborator

@teddyhwang teddyhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume this will be a major bump for the library given the dropped support for 7.3?

@paulomarg
Copy link
Contributor Author

Yes, I believe it should be a major bump. I'll update the changelog entry to make it clear it's a breaking change.

@paulomarg paulomarg merged commit fd40fad into main Feb 16, 2022
@paulomarg paulomarg deleted the update_php_to_v81 branch February 16, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teddyhwang teddyhwang teddyhwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulomarg @teddyhwang