Update session cookie expiration after OAuth #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
update_cookies_after_oauth
branch
from
1cc80fe to
fc34330
Compare
teddyhwang
approved these changes
Nov 30, 2021
paulomarg
force-pushed
the
update_cookies_after_oauth
branch
from
fc34330 to
d908392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #112
Currently, after OAuth is completed, we're not updating the session cookie's expiration time to match the session, which means the session is lost after a minute.
WHAT is this pull request doing?
Making sure we're also updating the cookie on the
callbackmethod for OAuth.Type of change
Checklist