Tests are broken for latest redis-client #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miry
requested review from
a team,
spike01,
atraver-shopify and
shopifyshuhei
and removed request for
a team
miry
force-pushed
the
320-downgrade-redis-client
branch
from
432ee37 to
6d2ce84
Compare
Update gitignore to have Gemfile.lock. It would allow to test gem against specific versions for dependencies.
miry
force-pushed
the
320-downgrade-redis-client
branch
from
6d2ce84 to
4b9af72
Compare
AbdulRahmanAlHamali
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current broken tests: https://github.com/Shopify/semian/runs/6526541521?check_suite_focus=true
Last success tests: https://github.com/Shopify/semian/runs/6229616802?check_suite_focus=true
The last compatible version was redis-client 0.2.0.
Move development dependencies to Gemfile.
Update gitignore to have Gemfile.lock.
It would allow to test gem against specific versions for dependencies.
Possible solution to check https://github.com/redis-rb/redis-client/blob/78c7932c28023ce8e1b9d64a04bd831cce539543/hiredis-client/lib/hiredis-client.rb