Ignore lines made long by cop directive comments #488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resets
Layout/LineLength
'sIgnoreCopDirectives
to its default -true
.Assuming a config of
Max: 20
, for example purposes, this would be an offense based on our current config:and the author would have to resort to the more verbose
We already allow test descriptions to be long. I argue a similar justification applies here and that the inline version is better.
There is another alternative
but that makes the line even longer than before, so I think it makes sense to just allow directives.